Hi,
Paul Martz wrote:
Wojciech Lewandowski wrote:
Paul,
Frankly, I would rather fix osgUtil::Optimizer than continue to
enforce this flawed concept of enum to unsigned int casts. Call me
stubborn, but will I simply take my stand on this issue. On the other
hand I am not so stubborn to not accept Robert and community decision.
So I propose to wait and let Robert have last word in our small
dispute. Besides I suspect he may want do few things differently,
anyway.
Well, I'm stubborn too. :-) Bits in a bitmask, as well as the bitmask
itself, should be unsigned, not signed, and I won't budge on this. It's
the right thing to do.
enums and bitmasks have never mixed well for me either.
If, as you say, enums are signed, then let's get rid of them and use a
"static unsigned int" declaration for each enum value. This was what we
did at my former employer and it worked fine.
You can even make it "static const unsigned int" :)
I've recently had a look at Google's protocol buffers and they also use
this approach. They have a global enum with mangled names and then in
the class there are "static const" versions.
But, like you, I respect that this is Robert's project, and ultimately
he has the final say on this issue.
-Paul
Can't wait for the verdict :)
rgds
jp
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
--
This message is subject to the CSIR's copyright terms and conditions, e-mail legal notice, and implemented Open Document Format (ODF) standard.
The full disclaimer details can be found at http://www.csir.co.za/disclaimer.html.
This message has been scanned for viruses and dangerous content by MailScanner,
and is believed to be clean. MailScanner thanks Transtec Computers for their support.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
