Hi Paul,
On Tue, Nov 10, 2009 at 5:02 PM, Paul Martz <[email protected]> wrote:
> The only question I have at this point is: Do you want me to do this
> resubmission work (scrap the current submission and make the mods as you
> outline below), or will you be doing this work?
>
> If you want me to resubmit, then let me know when svn trunk is at a good
> point for me to restart, and I'll do an update and make the changes from
> there.
I have now checked in my changes for the new OSG_GLx_FEATURES macro as
well as changes to FrameBufferObject so that it uses non EXT postfixed
names in it's function pointers, and also changes the macro to test
for both the sans EXT and with EXT extension names i.e. :
#define LOAD_FBO_EXT(name) setGLExtensionFuncPtr(name, (#name), (
std::string(#name)+std::string("EXT") ).c_str() )
And in the code it now reads:
LOAD_FBO_EXT(glBindRenderbuffer);
I've also removed the if (featureSupported) tests as these aren't
useful in the presence of inbuilt supported, and a couple of extra
checks at start up won't harm anyone without it.
The files I've just checked in are:
include/osg/FrameBufferObject
include/osg/GL
src/osg/FrameBufferObject.cpp
src/osg/GL2Extensions.cpp
src/osg/GLExtensions.cpp
src/osg/PointSprite.cpp
src/osg/State.cpp
src/osg/Texture.cpp
src/osg/TextureCubeMap.cpp
src/osg/TextureRectangle.cpp
src/osgUtil/RenderStage.cpp
There is some overlap with the files you changed for the GL3 support,
and hopefully I've got these changes right and the above files will
now just work under GL3 and you won't need to do anything more than
test them.
It would be worth you having a look at the changes I've just checked
in to see where I'm going with this, hopefully between us we'll be
able to come up with a set of changes that will keep the code base as
clean and readable as possible, and still get us all this loverly new
GLx support :-)
W.r.t the rest of the required changes I'll do a quick review at my
end against your original submissions. Where I can see a simple way
to enable GL3 support I'll do it and get it checked in and notify you.
This will probably take me another half hour so hang back till I've
done this.
BTW, openscenegraph.org isn't responding right now, but I'm able to
use subversion O.K, hopefully the problems in the server won't spill
over on to interferring with svn.
Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
