Robert Osfield wrote:
I'll hold back from merging the changes to GraphicsWindowWin32 as my
changes to Traits will have broken the build on these. I could have a
guess at fixing them, but am not comfortable with not being able to
compile test these changes.
Hm. You have made several other changes to GL3-specific code without
being able to test it, why not this as well?
Are you saying you want me to do an update and fix
GraphicsWindowWin32.cpp so that it works with your rewrite of my
submission? If so, please let me know and I'll take a look at it.
> I also have query about one of the
changes to GraphicsWindowWin32.cpp, could you explain why you removed
the ResotreContext code block from bool
GraphicsWindowWin32::realizeImplementation():
struct RestoreContext
{
RestoreContext()
{
_hdc = wglGetCurrentDC();
_hglrc = wglGetCurrentContext();
}
~RestoreContext()
{
if (_hdc)
{
wglMakeCurrent(_hdc,_hglrc);
}
}
protected:
HDC _hdc;
HGLRC _hglrc;
} restoreContext;
The reason why I'm perplexed by the removal of this code is that there
must have been a reason for the code in the first place, it seems odd
that this reason has just disappeared. I don't have any expertise or
experience with the GraphicsWindowWin32 so I have defer to experts
like yourself.
Thanks for any clarification you can provide.
I removed this struct definition because I could not see that it was
used anywhere. It was essentially dead code that was decreasing the
readability of the context creation.
-Paul
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
