Thanks J-S, changes now merged and submitted to svn/trunk. Cheers, Robert.
On Tue, Aug 25, 2009 at 3:45 AM, Jean-Sébastien Guay <[email protected]> wrote: > Hi Robert, > > Here are the updated files. The first problem was a simple omission on my > part, and I fixed the second as I said: > >> I think the second problem is "normal" because the default setting for >> WriteToFileOperation is OVERWRITE instead of SEQUENTIAL_NUMBER - we can >> change this if you think it makes more sense to set it to SEQUENTIAL_NUMBER >> by default. > > Since one of the features added by this change is a key to start continuous > capture, I think it makes sense to set the default capture operation to > sequentially number captured images. > > I also slipped in another small change, but that will make a big difference > for us - please tell me if you agree with it. > > Instead of WindowCaptureCallback::ContextData using a static int COUNTER > which it increments as its _index value in the constructor, I make it use > _gc->getState()->getContextID(). This has one important benefit for us, it's > that in the CaptureOperation, we can identify the context for which the > capture was taken and choose to save it or not. Before, the context_id that > was passed to CaptureOperation::operator() (which was the ContextData's > _index variable) was arbitrary, and might change between runs depending on > which context was the first to get captured, so we could not know if it > corresponded to the actual graphics context we needed to capture. > > As I said, let me know if that makes sense or if we should do this > differently. > > Thanks a lot, > > J-S > -- > ______________________________________________________ > Jean-Sebastien Guay [email protected] > http://www.cm-labs.com/ > http://whitestar02.webhop.org/ > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
