Thanks Christian, changes now merged perfectly (I used xxdiff) and changes all look pretty sensible. Changes now merged and submitted to svn/trunk.
As for openscenegraph.org... curious that svn is working fine, but the website not so it looks like the server is up, just website is not responding. Cheers, Robert. On Fri, Nov 27, 2009 at 4:38 PM, Christian Ehrlicher <[email protected]> wrote: > Hi, > > here a new try. Since www.openscenegraph.org seems to be down I could > not read the wiki page - I'll do so once it's working again. > Looks like my patch was screwed up because of windows/unix lineendings. > This time I took care to not modify anything else than the important things. > > I've attached the complete file and the patch. Hope it works now :) > > > Christian > > Robert Osfield schrieb: >> Hi Christian, >> >> Could you please send the complete modified file as patch is >> unreliable means of reviewing merging submission - your patch even >> fails to apply cleanly. >> >> Details of the submissions protocol can be found at: >> http://www.openscenegraph.org/projects/osg/wiki/MailingLists/SubmissionsProtocol >> >> Thanks, >> Robert. >> >> >> On Wed, Nov 25, 2009 at 5:54 AM, Christian Ehrlicher >> <[email protected]> wrote: >>> Hi, >>> >>> during profiling my program I found out that there's a lot of memory >>> (de)allocation going on in OverlayNode::cut(). >>> >>> So instead creating inner-loop variables 'distances' and 'newVertices' >>> every time, I moved the creation out of the loop and just do a clear() + >>> reserve() inside the loop. This allows std::vector<> to reuse the old >>> memory instead allocating new when the new size <= oldsize. >>> >>> >>> Christian Ehrlicher >>> >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
