Hi Julen, On Wed, Dec 2, 2009 at 4:01 PM, Julen Garcia <[email protected]> wrote: > I take the last version of the svn (with Rafa's changes) and add my code to > that.
Thanks for the clarification. I'm just doing the review. Could you explain the need for the changes to ffmpeg/CMakeLists.txt as the FindFFmpeg.cmake should supplying all the required include directories so I'm surprised you need to encode them into the CMakeLists.txt. I'm also surprised by the change of the ReaderWriterFFmpeg.cpp that changes the use of the path variable to filename, as this changes discards the usage of findDataFile() that is done higher up in the code, and is out of keeping with how the majority of the OSG plugins work. Could you explain this change too. The rest of the changes are a bit beyond my understanding of the ffmpeg plugin as it's still pretty new to me, so I'll have to trust that these are done appropriately. I'll do a test merge of these and see how I get on. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
