Hi Robert, Here is a modified fix. It doesn't break the other patch for this plugin as they are for different files. I've only added the file formats handled by default with DirectShow (based on its Wikipedia page). If you have codecs to handle other formats, you'll need to manually add them by preloading the plugin or adding the ".directshow" extension. To create this list at runtime, we should ask to Cedric as he's the creator of the plugin if it's possible... :)
Cheers, On Wed, Jan 6, 2010 at 5:54 PM, Robert Osfield <[email protected]>wrote: > Hi Serge, > > On Wed, Jan 6, 2010 at 4:33 PM, Serge Lages <[email protected]> wrote: > > Sorry for this submission, you're right that forcing to add .directshow > is a > > bit brutal. I'll make you another submission with a list of extensions > like > > the ffmpeg plugin does. Currently the problem with the directshow plugin > is > > that it try to handles every file going through it and it can produce a > > crash with some type of files. > > Added the extensions that it handles is something that I did original > expect for the plugin so am surprised that it didn't have any. I > guess directshow itself has a plugin architecture so the number of > formats it can handle is likely to not be fixed either. Might it be > possible to query directshow to find out what it supports at runtime? > > FYI, I have another submission that modifies the directshow plugin so > I'll review this, and if they changes all look appropriate I'll merge > and this would then be the appropriate base to make your own changes. > > Cheers, > Robert. > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > -- Serge Lages http://www.tharsis-software.com
ReaderWriterDirectShow.cpp
Description: Binary data
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
