Hi Sukender, On Tue, Jan 12, 2010 at 12:09 PM, Sukender <[email protected]> wrote: > Here are the files (in an archive), against rev. 10943. > I'm sorry about the coding style. I usually take a few minutes to change tabs > to spaces and ensure the whole looks a bit OSG-styled, but I may have > forgotten this time. I'll try to pay more attention next time. Be warned the > attached files haven't been modified!
I've done another review. What is the motivation by having the ProxyLoadCallback have it's own FileName parameter as osg::Image already has one. The load call can get the image and hence the FileName from it. The only reason I can spot so far is that you are using it in the compare method, but since you needn't do the compare here, as you could move it in to the Image::compare() then you'd have access to the required Image::getFileName(). My inclination is avoid data duplication where possible. An advantage of making ProxyLoadCallback stateless would be that you could attach on callback to many osg::Image. Thoughts? Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
