Hi Wang, These changes all look appropriate, and I fully agree with sorting out these methods so that they match set/get methods to make the job easier for wrapping, and just plain easier for end users. I've actually gone a bit further and removed the get methods in the form void getValue(type&) as these are quite inconsistent with the rest of the OSG and have both a type getValue() method as well would just confuse users.
Once you post the next code drop of the plugin I'll get it checked into svn/trunk. Many thanks for your efforts on the binary/ascii format Cheers, Robert. On Wed, Jan 13, 2010 at 12:57 PM, Wang Rui <[email protected]> wrote: > Hi Robert, > > Attached are two simple modifications of osg::Sequence and > osg::Texture1D classes, for the reason of implementing the I/O > serialization feature. In the Sequence header, I've added some more > convenient functions: setTimeList/getTimeList, > setLoopMode/getLoopMode, setBegin/getBegin, setEnd/getEnd, > setSpeed/getSpeed and setNumRepeats/getNumRepeats. > > In the Texture1D header, fixed: > > inline void setTextureWidth(int width) const ... > > to: > > inline void setTextureWidth(int width) ... > > No essential changes, but this will reduce the shuffle code of the > ascii/binary format plugin in processing. > > If the submission is accepted, I'd like to upload the osg_bin plugin > tomorrow. I've already finished all 103 OSG core class wrappers. :) > > Cheers, > > Wang Rui > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
