Hi Ryan,

Thanks for the in-depth investigation, explanation and changes.  I've
reviewed them and for now have just merged the changes relating to
removal of the TXPArchive from the ReaderWriterTXP.cpp.  Just before
merging I also did a tidy up of the indentation so when you do an svn
update you should spot this well.

The wider problem relating to DatabasePager not clearing it's
references to TXPPagedLOD's correctly is something that touches upon
other work I currently undertaking in a review of the DatabasePager.
The timing of my work is just co-incidence, as is the timing of David
Fries fixes to the DatabasePager which look at a different issue.

The focus of my own review is to look at removing the current scheme
for tracking the active and inactive PagedLOD's, and the need for
registering PagedLOD's with the DatabasePager.  My review touches upon
your work as I'm now moving towards a design where the DatabasePager
just keeps a weak/observer pointer relationship to PagedLOD's it's
tracking rather than a full ref_ptr<>.   I'm still getting my head
around how to tackle it so don't have anything to check in, but when I
do it would be very useful to have you test the changes w.r.t the
issues you've been seeing.

I'll post more details as my work progresses.

Robert.

On Tue, Feb 2, 2010 at 1:20 AM, Ryan H. Kawicki
<[email protected]> wrote:
> Full files included in this post.
>
> Thanks,
> Ryan
>
> ------------------
> Read this topic online here:
> http://forum.openscenegraph.org/viewtopic.php?p=23520#23520
>
>
>
>
> Attachments:
> http://forum.openscenegraph.org//files/txp_124.zip
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to