Hi Ryan, I've merged the changes and made a few extra tweaks such as a adding .get() to a couple of places to keep things compiling when automatic pointer conversion isn't enabled in ref_ptr<> and leaving of TXPParser::getArchive() and TXPParser::getArchive() so they still return Archive* rather than ref_ptr<>. These little changes shouldn't affect lifetime of objects but should avoid some unnecessary thrashing of ref counts.
An svn update will get these changes, could you please test them. I haven't yet tackled the management of PagedLOD in DatabasePager so that they are automatically freed yet, you did make a workaround this in the TXP plugin that I didn't merge so in your testing be aware of this. I will be tackling the management of PagedLOD in DatabasePager in the next week, the changes will have the pager not retaining any ref_ptr<PagedLOD> but using a custom observer instead, these changes should make your original changes to TXP w.r.t unreffing PagedLOD unnecessary, or at least that's my hope. When the changes my check in I'll ping you once more. Cheers, Robert. On Fri, Feb 12, 2010 at 7:31 PM, Ryan H. Kawicki <[email protected]>wrote: > I have a few additions that need to be incorporated into the trunk. > > I guess I missed these during my testing, but if the database pager has > outstanding requests while the application is shutting down, the archive can > become invalidated through unsafe calls to ReaderWriterTXP::getArchive. > I've made this function return a ref_ptr and change other locations to as > needed to conform to the change. I've tested this and no more crashes. > > Following files from revision 11057 have been attached. > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=24095#24095 > > > > > Attachments: > http://forum.openscenegraph.org//files/txp_162.zip > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
