Hi Sukender,
On Fri, Mar 5, 2010 at 12:10 PM, Sukender <[email protected]> wrote:
> Here is a tiny fix for getNameLessExtension(). It does now check for the
> presence of slashes ('/' and '\') to avoid changing the string when having a
> dot in a directory.
> Old behaviour: "abc.d/filename_no_ext" -> "abc"
> New behaviour: "abc.d/filename_no_ext" -> "abc.d/filename_no_ext"
>
>
Change now merged and submitted to svn/trunk. I changed the variable
antiSlash to back_slash so that it has the usual naming form this type of
slash.
> By the way, I spotted in the same file some filename.find_first_of("://").
> At first glance, it seems the goal is to find "://" substring. If so, the
> call isn't appropriate since it finds the first occurrence of ":" or "/",
> and not the first occurence of the string "://".
> If confirmed, it may be replaced with "find()".
>
Ooo, does look like it is a bug... I've just replaced find_first_of("://")
with find("://"), thanks for the spotting this error.
Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org