Hi Sukender,
On Tue, Mar 9, 2010 at 9:31 AM, Sukender <[email protected]> wrote:
> Here is my proposal. I fixed what Paul said, added some doxygen comments,
> added the function I told about, and removed the two "find('/')"-like calls
> to use only one.
Thanks, this is certainly an improvement.
> BTW, is there a reason for not doing the same in other functions, like
> getFilePath(), getSimpleFileName()...? If yes, I guess this code should be
> factorized. Else, those functions may be simplified.
>
Yes, it makes sense to fix these old methods as well. I've gone ahead and
implemented this as well put together a test for the file name extensions.
I've added the basic tests of FileNameUtils into osgunittests that you can
now invoke via:
osgunittests filenames
You need to review the output on screen, so it isn't automated but at least
it's a quick way to double check validity.
An svn update will get these changes.
Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
