Hi J.P, I've just merged a fix from Jason that is the same as yours so
svn update should get this fix.  Thanks Robert.

On Fri, Apr 9, 2010 at 9:49 AM, J.P. Delport <[email protected]> wrote:
> Hi Robert,
>
> we've been getting crashes in DatabasePager on certain machines when
> manipulating an earth database with svn head.
>
> The manipulation of the list for the request queue introduced in r11285
> seems to be the cause.
>
> What happens is that in the following lines
>
> ---8<---
> citr = _requestList.erase(citr);
> OSG_INFO<<"DatabasePager::RequestQueue::takeFirst(): Pruning
> "<<(*citr)<<std::endl;
> ---8<---
>
> citr (returned from erase) can become undereferenceable when the list goes
> empty and is then dereferenced in the OSG_INFO line.
>
> I've just swapped the lines in two places, which I think makes the info
> output and dereference correct. Seems to fix our crashes also.
>
> regards
> jp
>
> --
> This message is subject to the CSIR's copyright terms and conditions, e-mail
> legal notice, and implemented Open Document Format (ODF) standard. The full
> disclaimer details can be found at http://www.csir.co.za/disclaimer.html.
>
> This message has been scanned for viruses and dangerous content by
> MailScanner, and is believed to be clean.  MailScanner thanks Transtec
> Computers for their support.
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to