Hi J.P, Thanks for doing a double check, I assumed that because your submissions was tackling the same issue as Jason's they'd be identical, but they weren't... yours fixed two instances of the problem while Jason's just fixed one and I didn't spot the other case.
I've now merged you second change and checked it in svn/trunk. Thanks for you patience, Robert. On Thu, Apr 15, 2010 at 12:57 PM, J.P. Delport <[email protected]> wrote: > Hi Robert, > > looks like you've missed the other occurrence of the same problem. > > See attached. > > rgds > jp > > On 15/04/10 13:46, Robert Osfield wrote: >> >> Hi J.P, I've just merged a fix from Jason that is the same as yours so >> svn update should get this fix. Thanks Robert. >> >> On Fri, Apr 9, 2010 at 9:49 AM, J.P. Delport<[email protected]> wrote: >>> >>> Hi Robert, >>> >>> we've been getting crashes in DatabasePager on certain machines when >>> manipulating an earth database with svn head. >>> >>> The manipulation of the list for the request queue introduced in r11285 >>> seems to be the cause. >>> >>> What happens is that in the following lines >>> >>> ---8<--- >>> citr = _requestList.erase(citr); >>> OSG_INFO<<"DatabasePager::RequestQueue::takeFirst(): Pruning >>> "<<(*citr)<<std::endl; >>> ---8<--- >>> >>> citr (returned from erase) can become undereferenceable when the list >>> goes >>> empty and is then dereferenced in the OSG_INFO line. >>> >>> I've just swapped the lines in two places, which I think makes the info >>> output and dereference correct. Seems to fix our crashes also. >>> >>> regards >>> jp >>> >>> -- >>> This message is subject to the CSIR's copyright terms and conditions, >>> e-mail >>> legal notice, and implemented Open Document Format (ODF) standard. The >>> full >>> disclaimer details can be found at http://www.csir.co.za/disclaimer.html. >>> >>> This message has been scanned for viruses and dangerous content by >>> MailScanner, and is believed to be clean. MailScanner thanks Transtec >>> Computers for their support. >>> >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > -- > This message is subject to the CSIR's copyright terms and conditions, e-mail > legal notice, and implemented Open Document Format (ODF) standard. The full > disclaimer details can be found at http://www.csir.co.za/disclaimer.html. > > This message has been scanned for viruses and dangerous content by > MailScanner, and is believed to be clean. MailScanner thanks Transtec > Computers for their support. > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
