Hi Chris, I've just reviewed your changes, and feel that it needs and extra check against whether the makeCurrent() has succeeded or not - if it hasn't then the code should immediately return for the realizeImplementation() method and not attempt to do the wglGetProcAddress call as doing so could cause undefined behavior.
There is a check against the makeCurrent() result variable in the shared context code block, so I'd guess that it would be appropriate to just move this up to right after the makeCurrent(). Could you have another look at this code. Thanks, Robert. On Wed, Apr 14, 2010 at 12:19 AM, Chris 'Xenon' Hanson <[email protected]> wrote: > This implements the unimplemented Win32 vsync on/off functionality of the > traits class. > > It is related to Ulrich's runtime work of the same fashion, but does not > overlap, as you > must be very careful when initially setting this up since > wglGetProcAddress("wglSwapIntervalEXT") only works when there is a valid, > current OpenGl > context. > > -- > Chris 'Xenon' Hanson, omo sanza lettere Xenon AlphaPixel.com > PixelSense Landsat processing now available! http://www.alphapixel.com/demos/ > "There is no Truth. There is only Perception. To Perceive is to Exist." - Xen > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
