Hi Brad,
Changes look reasonable, now merged and submitted to svn/trunk. I've
had to fix the indentation a bit to keep it consistent with the rest
of the OSG and VPB - moving { and an else statement on their own
lines. It would be great if you could adopt the coding style of the
surrounding code for future submissions.
Cheers,
Robert.
On Wed, Aug 11, 2010 at 10:45 AM, Christiansen, Brad
<[email protected]> wrote:
> Hi Robert,
>
> I have made changes in two areas that effect VPBMaster's operation. The
> motivation for the changes come from writing a GUI front end to VPBMaster.
>
> The first is changes to the logging behavior:
> - If a master log file is set, this is now also used as the operations log.
> This adds more detail to the master log file (it is clearer what has
> happened, particularly in the case of errors).
> - Fixed a bug which meant the build log was not correctly passed to the
> DataSet.
>
>
> The second set of changes relate to the behavior of VPBMaster when a run is
> finished. Prior to my changes the VPBMaster executable would not terminate if
> the TaskManager had spawned any threads, even once all tasks had completed.
> To change this behavior so VPBMaster would exit on completion I made two
> changes:
>
> - Implemented the exit(int) function in TaskManager (it was defined in the
> header but had no implementation)
> - Called this method prior to VPBMaster returning from main so all thread are
> closed and VPBMaster exits cleanly.
>
> The changes were made against trunk revision 1014.
>
> Cheers,
>
> Brad
>
>
>
>
>
>
>
> DISCLAIMER:---------------------------------------------------------------------------
> This e-mail transmission and any documents, files and previous e-mail messages
> attached to it are private and confidential. They may contain proprietary or
> copyright
> material or information that is subject to legal professional privilege. They
> are for
> the use of the intended recipient only. Any unauthorised viewing, use,
> disclosure,
> copying, alteration, storage or distribution of, or reliance on, this message
> is
> strictly prohibited. No part may be reproduced, adapted or transmitted
> without the
> written permission of the owner. If you have received this transmission in
> error, or
> are not an authorised recipient, please immediately notify the sender by
> return email,
> delete this message and all copies from your e-mail system, and destroy any
> printed
> copies. Receipt by anyone other than the intended recipient should not be
> deemed a
> waiver of any privilege or protection. Thales Australia does not warrant or
> represent
> that this e-mail or any documents, files and previous e-mail messages
> attached are
> error or virus free.
> --------------------------------------------------------------------------------------
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
