Hi Heiko, On Mon, Feb 14, 2011 at 10:19 AM, Heiko Thiel <[email protected]> wrote: > But I ask me: Why I have implemented this? Because osg calculate currently > all values I need - but don't save them.
It's a programming philosophy - minimal and complete. Users can compute the delta themselves if they need it so by saving the previous frame stamp values. This approach keeps the base classes simpler. You are first users to make public request for a delta time in FrameStamp, and it's existed for over a decade so I can only presume that most users have coped just fine without it. > So my suggestion is to extent the frameStamp class by a method > setDeltaFrameTime(...) (+getDeltaFrameTime) and set the value in > Viewer::advance. So you write instead of: The FrameStamp has two times, the SimulationTime and the RefrenceTime, which is the one that you'd end the delta FrameTime? Would you need both? > Btw: In this method is a typo: "prevousReferenceTime" instead of > "prev_i_ousReferenceTime" Thanks for spotting this. I've did a search and replace to fix this. BTW, in future could you be more specific with suggestions about where to look as only grep was able to tell me where the typo was. The best way is to provide the actual fixed file as this is unambiguous. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
