Hi Eric, I'm just reviewing your changes. I'm curious about the removal of the calls to jas_image_clearfmts(). I can see that this call won't be multi-threaded as I'd guess it's operating on globals in jasper as not parameter is passed in, so I can undersant it's removal, however, the original authors must have placed the call there for a reason.
I can't find any good docs on Jasper that enable to see when and why jas_image_clearfmts() needs to be called, so can't work out what the effects might be of removing these calls. Do you understand the role of this method and how it might effects things? The removal of the calls to jas_init() all look sensble to me, I'll make these changes in svn/trunk ReaderWriterJP2.cpp and check them in once I've done some testing. Robert. On Mon, Feb 21, 2011 at 5:36 PM, Eric Buehler <[email protected]> wrote: > In order to handle threaded image loading when using Jasper, the jas_init() > and jas_cleanup() methods should only be called in the beginning and in the > destruction of the ReaderWriterJP2 object. Otherwise the image table that is > created by jasper, may be initialized more than once, causing the table to > change in the middle of use. > > Let me know if you have questions. > > Thanks, > > Eric > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=36912#36912 > > > > > Attachments: > http://forum.openscenegraph.org//files/readerwriterjp2_140.cpp > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
