Hi Eric, On Wed, Mar 9, 2011 at 12:07 PM, Robert Osfield <[email protected]> wrote: > I'm just reviewing your changes. I'm curious about the removal of > the calls to jas_image_clearfmts(). I can see that this call won't be > multi-threaded as I'd guess it's operating on globals in jasper as not > parameter is passed in, so I can undersant it's removal, however, the > original authors must have placed the call there for a reason. > > I can't find any good docs on Jasper that enable to see when and why > jas_image_clearfmts() needs to be called, so can't work out what the > effects might be of removing these calls. Do you understand the role > of this method and how it might effects things? > > The removal of the calls to jas_init() all look sensble to me, I'll > make these changes in svn/trunk ReaderWriterJP2.cpp and check them in > once I've done some testing.
With test of removal of jas_init() I found that the jas_image_clearfmts() calls then cause crashes on any subsequent image reads. Removing the all jas_image_clearfmts() fixes this issue, and allows for multiple images to be read safely. I can say wether this actually fixes any multi-threading issues, but it does at least appear to work find on my system so I've gone ahead and checked it in. What I have checked in is very similar to you changes, except I've gone ahead and removed the calls completely rathr than comment them out. Could you please test svn/trunk and let me know how you get on. Thanks, Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
