Hi Peter, On Wed, Mar 9, 2011 at 11:47 PM, Peter Hrenka <[email protected] > wrote: > > I had a look at you patch and most indentations > do look wrong for me with tab-width==8. The surounding > code does not use tabs at all. I can say from personal > experience that Robert has been picky about such things > before...
Thanks for pointing that out. I keep forgetting how Visual Studio mangles indentation. > But now it's time for me to be picky: > Why "Hits"? Everywhere else it says "Intersection". > While I am all in favor of variety I think > in this context we should stick to terms > that we already have and not needlessly introduce > new ones. So I would suggest: > I agree with you, the term "Intersection" would be better. I recently converted my code from using the older IntersectVisitor, which used the term "hits". I guess my brain didn't fully make the switch yet ;) I'll repost the patch with these changes. Cheers, Farshid > Cheers, > > Peter > -- > Vorstand/Board of Management: > Dr. Bernd Finkbeiner, Dr. Roland Niemeier, > Dr. Arno Steitz, Dr. Ingrid Zech > Vorsitzender des Aufsichtsrats/ > Chairman of the Supervisory Board: > Michel Lepert > Sitz/Registered Office: Tuebingen > Registergericht/Registration Court: Stuttgart > Registernummer/Commercial Register No.: HRB 382196 > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
