Hi Jorge, Thanks for the examples. I'm just diving into the review now. On a first look I've just listed the files in each directory and I'm surprised and bit troubled by just how much there is in each directory. There are lots of directorys that look emtpy to me like - the lib and obj directories - are these not just build directories? If so shouldn't these be deleted and let the build tools create these?
There are also .* files that feel like there are temporary files that probably aren't critical to the actual distribution of source. Having the same resources in both examples is not approrpiate. If we have to have resource files in an example then we certainly shoudln't be duplicating them. We usually place all the image data for examples out in OpenSceneGraph-Data. Is there a reason why they are local here? Might it even be possible to simply the examples so that they don't come with this payload? The example need just show how to integrate the OSG with Andriod, it doens't need to be anything more than something that brings up a model and allows basic user interaction like a manipulator and to close the app. Robert. $ find osgAndroidExampleGLES1 osgAndroidExampleGLES1 osgAndroidExampleGLES1/default.properties osgAndroidExampleGLES1/libs osgAndroidExampleGLES1/libs/armeabi osgAndroidExampleGLES1/libs/armeabi-v7a osgAndroidExampleGLES1/obj osgAndroidExampleGLES1/obj/local osgAndroidExampleGLES1/obj/local/armeabi osgAndroidExampleGLES1/obj/local/armeabi-v7a osgAndroidExampleGLES1/srcsgAndroidExampleGLES1/src/osg osgAndroidExampleGLES1/src/osg/AndroidExample osgAndroidExampleGLES1/src/osg/AndroidExample/osgViewer.java osgAndroidExampleGLES1/src/osg/AndroidExample/ColorPickerDialog.java osgAndroidExampleGLES1/src/osg/AndroidExample/EGLview.java osgAndroidExampleGLES1/src/osg/AndroidExample/osgNativeLib.java osgAndroidExampleGLES1/.classpath osgAndroidExampleGLES1/.project osgAndroidExampleGLES1/gen osgAndroidExampleGLES1/gen/osg osgAndroidExampleGLES1/gen/osg/AndroidExample osgAndroidExampleGLES1/gen/osg/AndroidExample/R.java osgAndroidExampleGLES1/res osgAndroidExampleGLES1/res/drawable-ldpi osgAndroidExampleGLES1/res/drawable-ldpi/osg.png osgAndroidExampleGLES1/res/drawable-mdpi osgAndroidExampleGLES1/res/drawable-mdpi/osg.png osgAndroidExampleGLES1/res/layout osgAndroidExampleGLES1/res/layout/dialog_text_entry.xml osgAndroidExampleGLES1/res/layout/ui_layout_gles.xml osgAndroidExampleGLES1/res/layout/main.xml osgAndroidExampleGLES1/res/drawable-hdpi osgAndroidExampleGLES1/res/drawable-hdpi/web_browser.png osgAndroidExampleGLES1/res/drawable-hdpi/osg.png osgAndroidExampleGLES1/res/drawable-hdpi/arrow_rotate_anticlockwise.png osgAndroidExampleGLES1/res/drawable-hdpi/arrow_rotate_clockwise.png osgAndroidExampleGLES1/res/values osgAndroidExampleGLES1/res/values/strings.xml osgAndroidExampleGLES1/res/menu osgAndroidExampleGLES1/res/menu/appmenu.xml osgAndroidExampleGLES1/jni osgAndroidExampleGLES1/jni/Application.mk osgAndroidExampleGLES1/jni/Android.mk osgAndroidExampleGLES1/jni/OsgMainApp.hpp osgAndroidExampleGLES1/jni/OsgMainApp.cpp osgAndroidExampleGLES1/jni/OsgAndroidNotifyHandler.hpp osgAndroidExampleGLES1/jni/OsgAndroidNotifyHandler.cpp osgAndroidExampleGLES1/jni/osgNativeLib.cpp osgAndroidExampleGLES1/assets osgAndroidExampleGLES1/proguard.cfg osgAndroidExampleGLES1/bin osgAndroidExampleGLES1/AndroidManifest.xml osgAndroidExampleGLES1/.cproject _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
