Hi, Robert,
I can answer some of your questions... On 06/08/2011 05:58 AM, Robert Osfield wrote:
Hi Jorge, Thanks for the examples. I'm just diving into the review now. On a first look I've just listed the files in each directory and I'm surprised and bit troubled by just how much there is in each directory. There are lots of directorys that look emtpy to me like - the lib and obj directories - are these not just build directories? If so shouldn't these be deleted and let the build tools create these?
Yes, you should be able to delete bin/, libs/, obj/ without a problem. You can also delete the gen/ directory, as the R.java file there is generated by the build system from the resources in res/.
There are also .* files that feel like there are temporary files that probably aren't critical to the actual distribution of source.
I'm not sure about those, as none of my Android projects have them. My guess is that Eclipse creates those, so they can be deleted as well.
Having the same resources in both examples is not approrpiate. If we have to have resource files in an example then we certainly shoudln't be duplicating them. We usually place all the image data for examples out in OpenSceneGraph-Data. Is there a reason why they are local here? Might it even be possible to simply the examples so that they don't come with this payload? The example need just show how to integrate the OSG with Andriod, it doens't need to be anything more than something that brings up a model and allows basic user interaction like a manipulator and to close the app.
This is a little bit sticky. I agree it would be ideal for the resources to be put in a common area, but the ant build system that all Android SDK projects use pretty much requires them to be local. The application's GUI is created in the .xml files in the res/layout directory. In order for the layout files to make use of the drawables (the .png files), they also need to be specified as resources in their own subdirectories of res/.
This is how the Android SDK expects things to be arranged. I'm not saying it's impossible for this to be changed, but changing it would be a big deal. It would also make the OSG example difficult to follow for anyone familiar with how things normally work on Android.
--"J" _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
