Hi Patrick, I have spent most of today trying to get the txp plugin submitted and the txp plugin in svn/trunk in similar enough state to do a proper review - the indentation between the two has diveraged significantly makig the job far more awkward than it really should be. There are also lots of other fixes in the runtime and build fixes svn/trunk version that haven't made it in your version the txp plugin which also have to be resolved. These types of problems really shoud have been resolved prior to submission.
Even when throwing away all the changes in svn/trunk and just going with your version of the plugin I hit up against build errors - I'm compiling under Kubuntu 11.04 with gcc 4.5.2, but I'd expect most unix systems would also have problems with build. Could it be that the code has only been compiled under Windows? As things stand the submission is a long way from being ready to merge into svn/trunk. If the changes had slid in easily I would have considered merging them for 3.0 but it's just far too great a risk, and will take too much of my time - I've already poured 5 hours into, so will be cutting my looses and getting back to other work. Once 3.0 is out the door we can return to reviewing this submission, but we'll need to push back lots of changes that are in svn/trunk into your own trpage code base as having to re-fix the code base everytime I merge a submission involve the trpage codebase is a huge waste of time and a big risk factor - it really isn't the way to develop code. Best regards, Robert. On Wed, Jun 15, 2011 at 3:09 PM, Patrick Lavoie <[email protected] > wrote: > *********************** > Warning: Your file, txp2.9.15.zip, contains more than 32 files after > decompression and cannot be scanned. > ***********-*********** > > Hi > > This zip file contains all the changes to support geocentric projection > with Terrapage (TXP) new format (2.3). > > The ability to publish geocentric format will be in TerraVista 6.2.1 > (around July 2011). > > Most of this implementation was done by Trajce Nikolov with the help of > some Presagis employees. > > These modifications were tested with OSG Viewer (regression testing also > have been done with the code provided).. These modifications also have also > been in-depth successfully tested by one of our customer who use OSG as part > of their IG Simulator. > > Please let me know if you are missing information. > > -- > *Patrick Lavoie* > Lead Consultant | *Presagis* > > *T.* +1 514 341.3874 *F.* +1 514 341.8018 *C.* +1 514 465.6439 > > > > AVIS DE CONFIDENTIALITÉ – CONFIDENTIALITY NOTICE > > Ce courriel est destiné exclusivement au(x) destinataire(s) mentionné(s) > ci-dessus et peut contenir de l'information privilégiée, confidentielle > et/ou dispensée de divulgation aux termes des lois applicables. Si vous avez > reçu ce message par erreur ou s'il ne vous est pas destiné, veuillez le > mentionner immédiatement à l'expéditeur, effacer ce courriel sans en faire > de copie et ne pas divulguer ou transmettre à quiconque ce courriel. > > > > This e-mail message is intended only for the above named recipient(s) and > may contain information that is privileged, confidential and/or exempt from > disclosure under applicable law. If you have received this message in error > or are not the named recipient(s), please immediately notify the sender, > delete this e-mail message without making a copy and do not disclose or > relay this e-mail message to anyone. > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
