Hi Patrick, On Thu, Jun 16, 2011 at 3:38 PM, Patrick Lavoie <[email protected] > wrote:
> Yes we (Presagis) have tested only on Windows but our customer is running > these modifications under Linux. > Perhaps it's an old version of Linux, it'll take merging the fixes from svn/trunk to address these. The OSG buidls across dozens of different platforms, we can't just limit to one to two platforms. As we compile across so many platforms the code base is really shaken down - and for Presagis it really should be taking note of these fixes and merging them as not only do their address build fixes but often the warnings on other platforms reveals subtle bugs in the code. Most of the files in the txp plugins (all the one that start with tr*) comes > from the Terre Vista software so I have no control over the indentation > changes that occurs in them (also these files are only tested under windows > at Presagis since Terra Vista only run on windows). > Do you not have the ability to submit fixes to code back original team? Could they not pull in the changes made to the OSG version? The way things stand it's a broken model of development, it just doesn't work efficiently. I can't go fixing problems that still exist in the same code. This same problem of having to fix previously fixed problems has happens numerous times now. The fact that exactly the same issue has happened against and wasted even more of more time is pretty gaulling. > If all the tr* are not updated like they are now there is some risk that > the TX plugin will not work with the database produce by the next version of > TerraVista 6.2.1 coming out at the end of the month. > I simply can't merge the code as it doesn't compile and has lots of regression w.r.t svn/trunk, and is way too risky. It's better than we ship what we have and then update later. I am also wondering whether it migth be best to just decouple the txp plugin for the core OSG and let the plugin be maintained seperatly - this way Presagis and the TXP user communtiy could take ownersip of it and sync it with the TerraVisita releases as well as target potentially target multiple versions of the OSG. > Just want to remind you that all these fix were made by Tracje Nikolov > between November 2010 and January 2011. > > Also Nick tried to add the fix that where committed to svn archive around > December 19,20 and these make OSG crash on Linux > The submission doesn't contain all the fixes to OSG svn/trunk. For instance the follow didn't make it in: http://www.openscenegraph.org/projects/osg/changeset/11999/OpenSceneGraph/trunk/src/osgPlugins/txp/ReaderWriterTXP.cpp I also made a number of fixes that a Coverity review highlighted. for our customer (which is being used OSG since version 1.6) ! There has never been an OSG-1.6 release, the last of the OSG-1.x series was OSG-1.2. Perhaps you mean OSG-2.6. > > When is version 3.0 due ? > Feature freeze and first release candidate is tomorrow, with an intended release date of end of next week. Robert.
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
