Hi Torben, I've just reviewed your changes and as they modify the ABI will mean that any such changes will need to go into svn/trunk to be part of the future 3.2 release. I will probably make a 3.0.1 from the OSG-3.0 branch this month so am inclined to hold back from merging ABI breaking elements to svn/trunk till after 3.0.1 as juggling the differnt changes is a bit awkward.
In terms of the review of changes I think the bool passed into the constructor would probably be better explained, and this applies more generally to the usage of the read callback for the loading of external tiles. Right now the classes doesn't explain about the usage of the osgSim::DatabaseCacheReadCallback and it's role in the classes operation, so this head begs for a proper explanation of this - I'll add this to svn/trunk and OSG-3.0 branch, so the extra option could then build upon this. The height of terrain changes seems a bit redudent as you can easily work this out from the height of the query point and the distance returned for the height above terrain. Since not all end users will actually need the height of the terrain it also doesn't seem appropriate to compute it just in case some users might need it. A better solution would be to just let users compute it themselves, or if we do wish to add a convinience function to get the height above terrain and the height of terrain have a convinience method that computes the height of the terrain on demand. Robert. On Sun, Jul 17, 2011 at 11:12 PM, Torben Dannhauer <[email protected]> wrote: > Hi Robert, > > because often people have difficulties to unterstand the HAT queries and the > line intersection tests (with/out loading highest LOD from disk), I extended > the osgSim::HeightAboveTerrain class. > It now offers an optional flag in the static method to configure if it should > use the currently loaded LOD or the highest available LOD on disk. > Additionaly I added support for HOT (HeightOfTerrain) queries, because it is > computed anyway while calculating HAT and I think it is also often used. > > osgSim::HeightAboveTerrain now supports: > - HAT on current LOD > - HAT on highest available LOD on disk. > - HOT on current LOD > - HOT on highest available LOD on disk. > > Please feel free to comment! > > Thank you! > > Cheers, > Torben > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=41417#41417 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
