Indeed, I missed this one.
It's a bit old, but after diving back into the code, I don't see any 
particular reason for the 4th profile to be treated differently from the 3 
others.

    Luc




De :
Robert Osfield <[email protected]>
A :
OpenSceneGraph Submissions <[email protected]>
Date:
07/02/2012 13:18
Objet :
Re: [osg-submissions] Bug correction in Collada (dae) reader
Envoyé par :
[email protected]



Hi Luc,

On 10 November 2011 11:27, Luc Frauciel <[email protected]> 
wrote:
> When dae plugin is used with  daeUseSequencedTextureUnitsoption, the
> transparency processing is done with the wrong texture unit
> I've remplaced the unused parameter diffuseColorName by the
> diffuseTextureUnit effectively used.

I've just reviewed your change and would like a bit more discussion
before I merge any changes.  What I'm a bit puzzled by is that you've
changed three of the four cases calls to
processTransparecySettings(..) so that it passes in the texture unit,
but there is a fourth call that you haven't modified and this one
passes a NULL as the last parameter, it looks like you missed this one
in your own work.

Thoughts?
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org





_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to