Thanks Riccardo, I agree changing to GL_RGB32F_ARB should be OK as one should really just be using HDR on hardware that can support it. Changes now merged and submitted to svn/trunk.
On 14 February 2012 16:04, Riccardo Corsi <[email protected]> wrote: > Hi Robert, > > please find attached a small patch for HDR plugin, > which simply set by default the internal pixel format to GL_RGB32F_ARB where > appropriate. > > In the current version there's a comment saying that the plugin set it > to GL_RGB8 (even when reading from float) to support old graphics cards, > but the comment dates back to 2004... > What's more I believe that it's correct to expect a floating texture format > if you're loading an hdr image. > It was quite troublesome for us to discover why our background image wasn't > showing hdr data... > > In case you accept the submission, I've removed the comment as it would be > misleading to leave it there. > > Thank you, > Ricky > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
