Hi Mathieu,

I have just reviewed your submission and looked into the relevant
plugins and to me it looks like something when amiss with the port to
use CMake, the shadow, terrain and view plugins are being setup to
build as osgshadow, osgterrain and osgviewer plugins respectively.  I
don't remember making this decision, and find it a bit odd, especially
considering the aliases in Registry.cpp are in the opposite directly.

The fact that this issue hasn't been flagged before suggests that few
people have been using the features.  I'm not yet decided upon whether
it'll be appropriate to change the plugins names to match Registry.cpp
or the Registry to match the plugins as you have down.  Given OSG-2.x
and 3.x have gone out with the incorrectly named plugins perhaps it
would be best to go with your solution...

Thoughts?
Robert.

On 23 February 2012 10:07, Mathieu MARACHE <[email protected]> wrote:
> Hi Robert,
> I was trying to play with the configuratiion files from the data but
> couldn't load them with osgviewer's -c CLI switch, this correction
> should make the alias work :-)
>
> --- a/src/osgDB/Registry.cpp
> +++ b/src/osgDB/Registry.cpp
> @@ -279,9 +279,9 @@ Registry::Registry()
>      addFileExtensionAlias("osgb", "osg");
>      addFileExtensionAlias("osgx", "osg");
>
> -    addFileExtensionAlias("osgShadow",  "shadow");
> -    addFileExtensionAlias("osgTerrain", "terrain");
> -    addFileExtensionAlias("osgViewer",  "view");
> +    addFileExtensionAlias("shadow",  "osgshadow");
> +    addFileExtensionAlias("terrain", "osgterrain");
> +    addFileExtensionAlias("view",  "osgviewer");
>
>      addFileExtensionAlias("sgi",  "rgb");
>      addFileExtensionAlias("rgba", "rgb");
>
> --
> Mathieu
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to