Hi Thomas,

I'm curious about the change your a proposing. i.e. adding:

#if OSG_GL_FIXED_FUNCTION_AVAILABLE

#endif

Around the the call to
state.applyTextureMode(0,GL_TEXTURE_2D,osg::StateAttribute::ON);

First thing I'd like to ask is why #if
OSG_GL_FIXED_FUNCTION_AVAILABLE, rather than #if
defined(OSG_GL_FIXED_FUNCTION_AVAILABLE)?  The later is used elsewhere
in the OSG when fixed function is required.  It would seem to me that
if OSG_GL_FIXED_FUNCTION_AVAILABLE is not defined then the #if will
fail to compile.

Robert.

On 23 February 2012 00:25, Thomas Hogarth <[email protected]> wrote:
> Hi Robert,
>
> I noticed you have gone through a lot of
> submissions lately but haven't spotted this in the trunk.
>
> Just a little reminder
> Tom
>
> On 8 December 2011 21:44, Thomas Hogarth <[email protected]> wrote:
>>
>> Hi Robert
>>
>> Attached is the fix for osgText when using mipmapping on gles2
>> (Glyph.cpp). In the end I changed the approach slightly so that if using
>> gles2 and mipmapping the subloadAllGlyphs together method is used as calling
>> glGenerateMipmaps after each subload is very slow.
>>
>> There is also a small adjustment to osgText.cpp to prevent gl warnings in
>> gles2 mode.
>>
>> These changes are from rtis original post but with the fixes to improve
>> performance.
>>
>> Cheers
>> Tom
>
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to