Thanks for the updates Chuck, changes now merged and submitted to svn/trunk.
On 7 March 2012 20:14, Chuck Seberino <[email protected]> wrote: > Robert, > > Attached are modified versions of RotateCylinderDragger and Projector files > that clean up the use of _onCylinder / isProjectionOnCylinder(). > > I have also made changes to the RotateCylinderDragger to provide a cylinder > ring with a thickness. It is totally optional, but IMHO makes the default > behavior work better than a solid cylinder (which typically obscures the > geometry you are trying to drag). Gives it a bit more to grab, especially in > the case where eyepoint and cylinder axis are near parallel. > > > > > Regards, > Chuck Seberino > > > On Mar 6, 2012, at 3:23 AM, Robert Osfield wrote: > >> HI Chuck, >> >> I have merged and checked in your changes to Projector. I agree that >> _onCylinder should go as it's no longer used, keeping it around will >> confuse maintenance as will having the method returning it's value so >> I'd suggest we remove this. I had a bash at these but found that this >> method is still used and it's value passed around but otherwise >> ignored. I did complete my quick experiment with removing the >> _onCylinder member and it's associated method as I thought for more >> feedback from yourself. Did you attempt to remove it? If not could >> you try as the knock on changes required where the public accessor >> method is called might be more familiar with yourself. I think we >> need to clean up all the method and code that used to use the >> isProjectionOnCylinder() value. >> >> Thoughts? >> Robert. >> >> On 5 March 2012 23:05, Chuck Seberino <[email protected]> wrote: >>> Robert, >>> >>> Here is a fix for the RotateCylinderDragger. This patch fixes the case >>> where the picking direction is close to the cylinder axis. The current >>> behavior is this: >>> >>> * If the eyepoint and cylinder axis are close to parallel (given some >>> tolerance), then it uses a plane perpendicular to the cylinder axis. >>> * Otherwise it uses a plane parallel to the cylinder axis oriented towards >>> the eyepoint (previous behavior). This gives decent behavior and is the >>> only path that was taken in the previous code. I kept with previous >>> behavior and that allowed a good bit of code to be removed, simplifying >>> things. There is now no need for the _onCylinder flag, but since there is >>> a public accessor, I wasn't sure how to handle it for backwards >>> compatibility, so I left it in. NOTE - there is no default initialized >>> value, so if it is kept in, it should be set to 'false' to keep same >>> behavior as before. I am not quite sure how the _onCylinder case was >>> supposed to behave as even forcing that path gave undesirable behavior, >>> even with carefully controlled dragging. >>> >>> Please take a look and let me know if you have any questions or feedback. >>> >>> Thanks >>> Chuck Seberino >>> >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
