Dear all, I am an employee of dGB Earth Sciences, and we are currently porting the 3D visualization of our open-source seismic interpretation package OpendTect to OpenSceneGraph.
I want to submit three minor dragger fixes in osgManipulator. It concerns the files Dragger.cpp, TabPlaneDragger and TabPlaneDragger.cpp. The changed files have been drawn from the last public release OSG 3.0.1, and have been attached to this email. A> Missing break in switch statement at following function of Dragger.cpp: bool Dragger::handle(const osgGA::GUIEventAdapter&, osgGA::GUIActionAdapter&) The case osgGA::GUIEventAdapter::PUSH has no terminating break statement. This was discovered because I was twice receiving a DraggerCallback with its MotionCommand-stage set to osgManipulator::MotionCommand::START. B> Missing body implementation at following function of Dragger.cpp: Dragger::removeDraggerCallback(DraggerCallback* dc) While using DraggerCallbacks in my application, this omission resulted into a crash at removal time. I have added its body implementation analog to the Dragger::removeTransformUpdating(.,.) function in the same file. C> Added a default parameter to the following constructor in TabPlaneDragger and TabPlaneDragger.cpp: TabPlaneDragger(float handleScaleFactor=20.0f); The reason for this is that the default OSG tab sizes are way bigger than those we used in our application so far. And since handleScaleFactor_ is already a (constant) class member, I see no objection against making it user defined. A different solution may be preferred. For example, the handleScaleFactor parameter might be added to the function setupDefaultGeometry(bool) instead. Or a separate function setScaleFactor(float) might be added, although that will only help when it is called before setting up the geometry. Best regards, Jaap Glas -- -- dr. Jaap C. Glas -- Software Engineer -- dGB Earth Sciences -- Nijverheidstraat 11-2 -- 7511 JM Enschede, The Netherlands -- [email protected] -- http://www.dgbes.com -- Tel: +31 534315155, Fax: +31 534315104
osgManipulator.tar.gz
Description: GNU Zip compressed data
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
