Hi Jaap, I've reviewed and merged change items A, themissing break, and B, missing removeDraggerCallback implementation. These changes are now in svn/trunk. I haven't yet merged item C as will need to reflect on the topic further.
I would recommend updating to svn/trunk so that you can work on all the additional changes checked into osgManipulator since the 3.0.1 release. Cheers, Robert. On 24 May 2012 16:04, Jaap Glas <[email protected]> wrote: > A> Missing break in switch statement at following function of Dragger.cpp: > > bool Dragger::handle(const osgGA::GUIEventAdapter&, > osgGA::GUIActionAdapter&) > > The case osgGA::GUIEventAdapter::PUSH has no terminating break statement. > This was discovered because I was twice receiving a DraggerCallback with > its MotionCommand-stage set to osgManipulator::MotionCommand::START. > > > B> Missing body implementation at following function of Dragger.cpp: > > Dragger::removeDraggerCallback(DraggerCallback* dc) > > While using DraggerCallbacks in my application, this omission resulted > into a crash at removal time. I have added its body implementation analog > to the Dragger::removeTransformUpdating(.,.) function in the same file. > > > C> Added a default parameter to the following constructor in TabPlaneDragger > and TabPlaneDragger.cpp: > > TabPlaneDragger(float handleScaleFactor=20.0f); > > The reason for this is that the default OSG tab sizes are way bigger than > those we used in our application so far. And since handleScaleFactor_ > is already a (constant) class member, I see no objection against making > it user defined. > > A different solution may be preferred. For example, the handleScaleFactor > parameter might be added to the function setupDefaultGeometry(bool) instead. > Or a separate function setScaleFactor(float) might be added, although that > will only help when it is called before setting up the geometry. > > > Best regards, > > Jaap Glas > > -- > -- dr. Jaap C. Glas > -- Software Engineer > -- dGB Earth Sciences > -- Nijverheidstraat 11-2 > -- 7511 JM Enschede, The Netherlands > -- [email protected] > -- http://www.dgbes.com > -- Tel: +31 534315155, Fax: +31 534315104 > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
