Hi Martin,

Thanks for the submission, I've just done an initial pass through and
have to say I'm perplexed.  This problem you are trying to resolved is
an issue with Qt5 yet requires lots of odd new methods to the core OSG
classes, these new methods aren't needed and don't have any relevance
to normal OSG usage.  The design of GraphicsContext and the
relationship with GraphicsThread is something that has been carefully
developed and is widely tested across  a range of platforms and works
well, it should have all the required hooks to be able to work
correctly across windowing toolkits.  The type of intrusive changes
you've made to the core OSG really don't feel right, my gut instinct
tells me that you've made these changes to workaround problems in
osgQt or Qt5, rather than resolving the later.

I haven't investigated so don't understand the nature of the current
threading problem under Qt5, but for sure I would expect the solution
to be wholly within the osgQt or Qt examples.  There are times when we
have to make changes to the core OSG to accommodate platform specific
oddities but these are done with lots of dicsussion about the nature
of the problem being addressed and how it might be done with an eye to
avoiding intrusive changes to the core OSG.  I believe the right thing
to do at this point is discuss the nature of threading problem under
Qt5/OSG on the osg-users mailing list/forum, your solution can form
part of the discussion, but I'd like to see the discussion move
towards changes that aren't intrusive to the rest of the OSG as we
neither want superfluous API bloating the core classes, or risking
breaking existing functionality on other platforms.

Thanks,
Robert.



On 12 June 2013 11:28, Martin Scheffler <[email protected]> wrote:
> Hi,
>
> from this thread:, a fix to allow mulithreaded rendering with osgQt.
>
> http://forum.openscenegraph.org/viewtopic.php?t=11442
>
> Fix works OK for me.
> I am not sure if I placed the calls to prepare() and moveBack() to their 
> optimal places, but everything seems to work fine.
>
>
> Thank you!
>
> Cheers,
> Martin
>
> ------------------
> Read this topic online here:
> http://forum.openscenegraph.org/viewtopic.php?p=54555#54555
>
>
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to