Thanks for catching all these bugs. Now merged and submitted to svn/trunk.
Looks like I'll need to make 3.2.1 sooner rather than later :-) On 31 July 2013 19:01, Jolley, Thomas P <[email protected]> wrote: > Hi Robert, > > Thank you for making the change. > > I found a couple more bugs after closely looking at the small piece of > deprecated geometry in my model. There were problems with more than one > primitive in a couple places. The first was the number of vertices were not > being accumulated for DrawArraysPrimitiveType (caused another crash). The > second is I had to move target_vindex and source_pindex before the > PrimitiveSetList loop so they don't get reset on the next primitive > (otherwise you end up with a lot of zeros in per vertex lists). > > ---- > Tom Jolley > > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Robert > Osfield > Sent: Wednesday, July 31, 2013 1:57 AM > To: OpenSceneGraph Submissions > Subject: Re: [osg-submissions] Geometry bug > > Hi Tom, > > On 26 July 2013 22:05, Jolley, Thomas P <[email protected]> wrote: >> I ran across this error reading one of our older files. An iterator >> was being changed inside a loop that caused a crash. > > I've just done a review and initially I thought the original code was right > and had to go back and look at the implementation details of DrawArrayLengths > and found that my recent interpretation in the > Geometry::fixDeprecatedData() assumed that the array was a glDrawElements > style storage not glDrawArray length. All I can say is ooops, I got it wrong > :-) > > Your code does look correct and is now merged with svn/trunk and the > OSG-3.2 branch. I'll be making an OSG-3.2.1 release at some point in the > next month or two. I won't jump right away as it's like that other issues > will appear once more testing is done. > > Cheers, > Robert. > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
