Hi Anish, I have done another review of the DelaunayContraint::makeDrawable() and now understand it better, a little confusing Marco the orignal author uses member varable_ name rather than the OSG traditional member _variable convention so I mistakenlly read it as local variable, so there isn't the leak I thought there might be on first glance. I have merge and checked in your if (empty) return 0 style block into snv/trunk and OSG-3.2 as I feel this is apprpriate, although at this stage I don't think creating empty DrawElementsUInt will cause a leak.
The change to the destructor looks to be unccessary both from the official rules from delete NULL are for a non op and there also shouldn't be any null pointers in the list anyway, if there are it points to a problem elsewhere that I haven't spotted. If you are getting crashes that this address I would suspect a bug in the compiler and a bug elsewhere in the code that these changes just hide. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
