Hi Kristofer, Thanks for the fix, now merged and submitted to svn/trunk. I really should have spotted this in my review, but have to admit to not looking close enough at the visual results.
In testing this time I decided to fix the example so that the vertical and horizon scalar bars are rotated to the XZ plane so you can see them with the default viewer's camera orientation. I also Tweaked the positioning of title text of vertic scalar bar to avoid overlap of text. Cheers, Robert. On 27 January 2014 08:46, Kristofer Tingdahl <[email protected]>wrote: > Dear Robert, > > my colleague pointed out today that the vertical bar is upside down, and > hence not as the documentation says it should be. This is corrected with > this patch. Sorry for the inconvenience ;-( > > > - Kristofer > > > On 24 January 2014 17:20, Robert Osfield <[email protected]> wrote: > >> Thanks Kristofer, changes look good and the example works nicely once >> again. Changes now merged and submitted to svn/trunk. Cheers, Robert. >> >> >> On 24 January 2014 09:59, Kristofer Tingdahl < >> [email protected]> wrote: >> >>> Dear Robert, >>> >>> Thanks for the input. It is true that it does not render as it did >>> before, but it renders as the documentation says it should render. In my >>> view, the vertical bar was not correctly rotated. Instead of doing what the >>> documentation said (and which is logical: go along the Y axis), it still >>> was aligned with the x-axis (though sitting in the XZ plane rather than in >>> the XY plane). With my patch, it renders in the XY plane (as the Horizonal >>> one), but it goes along the Y axis. >>> >>> To illustrate this, I have modified the example program to render both a >>> horizontal and a vertical in the scene so the difference can be seen. >>> >>> Compared to my previous revision, I have fixed the flaw with the title >>> being in the wrong plane on the vertical one, and I have also repositioned >>> it to the top of the vertical one. Further, I have made the ticks on the >>> colortable shorter to make it more compact. >>> >>> Please advice, >>> >>> >>> Kristofer >>> >>> -- >>> Kristofer Tingdahl, Ph. D. >>> CEO >>> dGB Earth Sciences >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > > > -- > Kristofer Tingdahl, Ph. D. > CEO > dGB Earth Sciences > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
