That all seems reasonable, Robert.

However, I'm unqualified to create and submit such a change myself, as my
testing options are limited to OSX and Windows. I'd gladly review and test
a more comprehensive fix, but will have to politely bow out of developing
it myself. Please keep me posted.
   -Paul


On Mon, Apr 14, 2014 at 9:11 AM, Robert Osfield <[email protected]>wrote:

> HI Paul,
>
> Thanks for the files.  I have now done a first past review and am left
> wondering if this solution shouldn't just be for GL3 on WIndows, but
> OpenGL/OpenGL ES on all platforms.  In particular I wonder if the
> auto-generated include/osg/Config file we have could have the header
> definition to use, and have this filled out based on values that CMake
> establishes.
>
> Thoughts?
> Robert.
>
> On 12 April 2014 21:03, Paul Martz <[email protected]> wrote:
> > No problem, here is a zip file containing:
> > root-level CMakeLists.txt
> > CMakeModules/FindGL3.cmake
> > CMakeModules/OsgMacroUtils.cmake
> > include/osg/GL
> >
> >
> > On Sat, Apr 12, 2014 at 10:55 AM, Robert Osfield <
> [email protected]>
> > wrote:
> >>
> >> HI Paul,
> >>
> >> I can't find your post in my archives and the one one osg-submissions
> >> archives doesn't provide the attachements in a form that I can use.
> >> Could you repost the files?
> >>
> >> Thanks,
> >> Robert.
> >>
> >> On 12 April 2014 16:23, Paul Martz <[email protected]> wrote:
> >> > Hi Robert -- I saw you processed one of my submissions for GL3, but
> the
> >> > post
> >> > below has not yet been processed. I just wanted to make sure it hasn't
> >> > fallen through the cracks. Thanks.
> >> >    -Paul
> >> >
> >> >
> >> >
> >> > On Fri, Feb 7, 2014 at 2:42 PM, Paul Martz <[email protected]>
> wrote:
> >> >>
> >> >> Hi Robert -- Here's my change to make it possible to find the OpenGL
> 3
> >> >> header using cmake command line, rather than being forced to use
> >> >> cmake-gui
> >> >> and manually edit CMAKE_CXX_FLAGS.
> >> >>
> >> >> This also modifies the GL header to find the current opengl.org
> >> >> standard
> >> >> <gl/glcorearb.h> for core profile usage.
> >> >>
> >> >> Files:
> >> >> CMakeLists.txt
> >> >> CMakeModules/FindGL3.cmake
> >> >> CMakeModules/OsgMacroUtils.cmake
> >> >> include/osg/GL
> >> >>
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to