HI Pjotr,
I have gone ahead and merged the changes with a small change to the
problem copy constructor, I simply implemented it as per how other
osg::Object copy constructors are usually done.
RigComputeBoundingBoxCallback(const
RigComputeBoundingBoxCallback& rhs, const osg::CopyOp& copyop) :
osg::Drawable::ComputeBoundingBoxCallback(rhs, copyop),
_computed(false),
_factor(rhs._factor) {}
This implements the constructor and addresses the compile warning.
With this change the submission is merged and checked into svn/trunk.
Robert.
On 29 April 2014 15:56, Robert Osfield <[email protected]> wrote:
> Hi Pjotr,
>
> I am currently reviewing these changes and have come across the
> following warning when merging:
>
> /home/robert/OpenSceneGraph/include/osgAnimation/RigGeometry:32:124:
> warning: delegating constructors only available with -std=c++11 or
> -std=gnu++11 [enabled by default]
> RigComputeBoundingBoxCallback(const
> ComputeBoundingBoxCallback&, const
> osg::CopyOp&):RigComputeBoundingBoxCallback(){}
>
> Which hints that the code won't build on older versions of C++
> compilers that we need to retain compatibility with. Thoughts?
>
> Robert.
>
> On 17 April 2014 13:02, Pjotr Svetachov <[email protected]> wrote:
>> Hi Robert,
>>
>> I have added some missing serializers for RigGeomery. Withouth them I
>> ran into two issues.
>>
>> At first you get a bunch of warnings that osg::ComputeBoundCallback
>> and osg::UpdateCallback were unsupported wrapper classes when
>> converting fbx models with skeletal animation to osg(t/b).
>>
>> The second issue was that when reading, the readers fail to read the
>> ComputeBoundCallback and UpdateCallback and set them to NULL which
>> messes up the RigGeometry.
>>
>> Because a RigGeometry makes his own classes in the constructor it
>> might be preferable to not write them at all, because now those
>> classes are being made two times when reading a RigGeometry. But after
>> thinking about this that would place too much limits on them (you
>> won't be able to share or name them and save that information or make
>> a new inherited class from them and write that one) So I ended up
>> thinking the best way was to just write the files.
>>
>> By the way: I'm not that familiar with the new serialization system so
>> I hope I added them the right way :)
>>
>> Cheers,
>> Pjotr
>>
>> _______________________________________________
>> osg-submissions mailing list
>> [email protected]
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
