Hi Alexander, I have just done a first pass review of thet changes and they look good so far. I haven't merged yet but will do so soon.
Is there any need to add the toggle of whether to use glTextStorage2D? It seems like it should be used by default where supported. Do you know of any downsides to calling glTexStorage2D? Robert. On 28 May 2014 09:51, Alexander Sinditskiy <[email protected]> wrote: > Hi, > > My changes added support for gltexstorrage2d for texture2d. > > Initially I described issue in message: > http://forum.openscenegraph.org/viewtopic.php?t=13820 > It solves issue with compiling texture using ico from image with mipmaps > > I added enviroment variable OSG_GL_TEXTURE_STORAGE_ENABLE to control usage of > glTexStorage2d. Initially it is disabled. > > It used only if image have mipmaps. > > Another issue is converting from internalFormat + type to sized internal > format. I created sizedInternalFormats[] struct where sized internal formats > are ordered from worse->best. > also this struct have commented lines. Commented formats are listed in > http://www.opengl.org/wiki/GLAPI/glTexStorage2D > but looks like not using in osg. > > Thank you! > > Cheers, > Alexander > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=59587#59587 > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
