Hi, Robert
robertosfield wrote: > Hi Alexander, > > I have just done a first pass review of thet changes and they look > good so far. I haven't merged yet but will do so soon. > > Is there any need to add the toggle of whether to use glTextStorage2D? > It seems like it should be used by default where supported. Do you > know of any downsides to calling glTexStorage2D? > > Robert. > I was affraid of "immutable-format" but seems that changes of texture format and dimessions controlled in osg too -> osg::Texture::applyTexImage2D_subload from http://www.opengl.org/wiki/GLAPI/glTexStorage2D glTexStorage2D ... Once a texture is specified with this command, the format and dimensions of all levels become immutable unless it is a proxy texture. The contents of the image may still be modified, however, its storage requirements may not change. Such a texture is referred to as an immutable-format texture. I don't see any other downsides of gltexstorrage.But I think it would be nice to have OSG_GL_TEXTURE_STORAGE_ENABLE to force disable it. For example if it's bad supported on some rare hardware. yes, I agree with you that it should be used by default where supported. Thank you! Cheers, Alexander ------------------ Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=59887#59887 _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
