Hi Jannik, I have done a quick review of the changes and but I need to think about the topic so more before I merge the changes to Renderer. The changes to RenderStage.cpp are a straight bug fix so are now merged and submitted to svn/trunk and OSG-3.2 branch.
Cheers, Robert. On 17 June 2015 at 00:51, Jannik Heller <[email protected]> wrote: > Reading the code again, I believe my patch causes a race condition with > the _compileOnNextDraw flag, although I hadn't noticed this in practice. > > Renderer::compile runs a visitor on the scene graph, so can't safely run > in parallel with the user's main thread. > > The solution you will find in the attachment, is to break frame in begin > of draw() rather than end of cull() when the _compileOnNextDraw flag is on. > > Cheers, > Jannik > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
