Hi Robert sorry for the delay in reply. I was consulting with the engineer that made that change and we do need those lines uncommented. The reason is that our analysis tools could not read the unsigned tiff data without the tag present. If you notice in the switch statement for img.getDataType around line 910, the rowsperstrip tag is being set for float data but not for signed or unsigned short. upon further inspection, it seems that the two lines should be just before the switch statement so that the tag is set for all data types.
On Fri, Jul 17, 2015 at 4:19 AM, Robert Osfield <[email protected]> wrote: > Hi Patrick, > > I haven't yet had any feedback of the TIFFTAG_ROWSPERSTRIP so haven't > merged this change, but the rest of the changes look fine to me so are > now merged and checked into OSG svn/trunk, OSG-3.4 branch and OSG-3.2 > branch. > > If there is a need for commenting the following lines in, could you > please justify it > > > //uint32 rowsperstrip = TIFFDefaultStripSize(image, -1); > > //TIFFSetField(image, TIFFTAG_ROWSPERSTRIP, rowsperstrip); > > Thanks, > Robert. > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
