Hi Robert, Sorry, I don't remember the reason for commenting those lines out. My memory isn't what it used to be :)
I'm guessing I was experimenting with various fields and simply forgot to remove those lines. I just tried uncommenting the lines and it didn't appear to make any difference when writing out a standard RGB image. Cheers, Farshid On Thu, Jul 16, 2015 at 12:39 PM, Robert Osfield <[email protected]> wrote: > Hi Patrick (and Farshid), > > I have just done a first pass review and noticed that you have > commented back in the lines: > > //uint32 rowsperstrip = TIFFDefaultStripSize(image, -1); > //TIFFSetField(image, TIFFTAG_ROWSPERSTRIP, rowsperstrip); > > I've checked the archives and these were actually commented out right > in the first submission of the tiff write code that Farshid Lashkari > wrote back in 2006: > > > https://github.com/openscenegraph/osg/commit/d5063c3d0c0127577e9d2e9a85ec69bf59a569b4 > > I haven't worked specifically with this bit of code so can't on > Farshid's motivation for commenting out these lines, it may be have > been that the lines made no difference at that time, but it could also > be that it's inclusion caused a problem. I've added Farshid into this > reply to get feedback from him. > > What is your reason for for commenting these lines in? > > Robert. > > > On 16 July 2015 at 19:53, Patrick Neary <[email protected]> wrote: > > To the tiff plugin, add the capability to write tiff images with unsigned > > short data > > > > > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
