Hi Ralf,
On 26 May 2016 at 19:03, Ralf Habacker <[email protected]> wrote:
>> Do you have github fork of the OSG where you've made these changes?
> yes, see
> https://github.com/rhabacker/osg/commit/a369a6b9631020bbff079ea7d809b7c96c5f5746
Thanks. Wow, that's an amazing error to have in the code and quite
amazing that non of the compilers produce even warnings on it.
As an experiment I've just commented out the write and read methods
from the base class thus:
class ReadWrite{
public:
virtual ~ReadWrite() {}
#if 0
virtual void write(DataOutputStream* out) const = 0;
virtual void read(DataInputStream* out) const = 0;
#endif
};
And it compiles just fine. Just so these methods are actually never
used as the plugin always does a C cast to the subclass directly
rather than calling via the base class. This makes the base class
rather superfluous.
FYI, I'm not the original author of the IVE plugin so comment on the
intention here. You amendment does seem like the correct fix w.r.t
C++, but design/implementation wise the base class looks completely
superfluous.
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
