Am 26.05.2016 um 20:48 schrieb Robert Osfield: > Hi Ralf, > > On 26 May 2016 at 19:03, Ralf Habacker <[email protected]> wrote: >>> Do you have github fork of the OSG where you've made these changes? >> yes, see >> https://github.com/rhabacker/osg/commit/a369a6b9631020bbff079ea7d809b7c96c5f5746 > Thanks. Wow, that's an amazing error to have in the code and quite > amazing that non of the compilers produce even warnings on it. http://stackoverflow.com/questions/497630/safely-override-c-virtual-functions says that |-Woverloaded-virtual show such issues for gcc. After adding it to gcc cxxflags I get: | In file included from /home/xxxx/src/openscenegraph/src/osgPlugins/ive/AnimationPath.h:5:0, from /home/xxx/src/openscenegraph/src/osgPlugins/ive/AnimationPath.cpp:16: /home/xxxx/src/openscenegraph/src/osgPlugins/ive/ReadWrite.h:186:18: warning: ‘virtual void ive::ReadWrite::write(ive::DataOutputStream*) const’ was hidden [-Woverloaded-virtual] virtual void write(DataOutputStream* out) const = 0;
> FYI, I'm not the original author of the IVE plugin so comment on the > intention here. You amendment does seem like the correct fix w.r.t > C++, but design/implementation wise the base class looks completely > superfluous. I guess the main idea was to make sure that those methods need to be implemented in derived classes and that they are virtual, so the fix should be applied. Ralf
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
