Hi Stuart, I have just reviewed your changes and don't feel confident that any of them will apply safely without breaking the build for other people.
If you feel there are issues that need resolving then I think you should raise the individual issues on osg-users mailing list/forum. Some of the issues might be fixable simply using cmake setup others might be tweaking the install of 3rd party dependencies, some may indeed require changes to the OSG's Find or CMake scripts but if we do make these changes they have to be backwards compatible as most users have been getting on just fine with the scripts as they are so changing them risks breaking things for the majority of users. Cheers, Robert. On 16 May 2016 at 11:23, Stuart Mentzer <[email protected]> wrote: > Hi Julien, > > You are correct about the SDK -- it is being set up properly with the VS > environment. So the submitted changes to the top-level CMakeLists.txt are not > needed. > > The other submissions should be relevant but I'm not proposing that they be > integrated verbatim. > > The current freetype release has include path changes. I'm not sure how to > support both old and new freetype setups in the same FindFreetype.cmake file. > > Qt 5 is handled differently by CMake than Qt 4. The switch to > target_link_libraries may be optional but building without the FIND_PACKAGE > additions fails. > > Cheers, > Stuart > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=67110#67110 > > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
