Hi Jethro, I have just done a first pass review.
The interpretation of GL_LINE_STRIP_ADJACENCY is something that is shader dependent, it might not be generating a line at all. This is a potential issue for all shaders so isn't alone in this issue. In terms of completing the implementation, we have the TriangleIndexFunctor and TriangleFunctor to do as well. The appropriate default interpretation of the ADJACENCY is something we'd need to settle upon. What are you currently using *ADJACENCY for? What part of the TemplatePrimitiveFunctor are you requiring? Finally what author attribute would you like me to use for you? Now we are on github I can use email address associated with a contibutors github account to enable an attribution directly to their github page. Thanks, Robert. On 6 June 2016 at 03:44, Jethro Leevers <[email protected]> wrote: > Hi, > > I have attached the changes I have made to: > include\osg\TemplatePrimitiveFunctor > > Their is room to add the 3 remaining adjacency modes. > > > Thank you! > > Cheers, > Jethro > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=67432#67432 > > > > > Attachments: > http://forum.openscenegraph.org//files/4789_1465181050._527. > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
