Hi Vladimir, Sorry for the delay on reviewing these changes, I've been busy boy!
The changes look fine for me, now merged and checked into OSG master. Cheers, Robert. On 29 November 2016 at 18:51, Robert Osfield <robert.osfi...@gmail.com> wrote: > Hi Vladimir, > > I'm currently waiting for a quieter period work wise before I dive > back in with submissions. I should get back to submissions in the > next week or two. > > Cheers, > Robert. > > On 16 November 2016 at 11:46, Chebaev Vladimir <aluminium...@yandex.ru> wrote: >> Hello. >> Sorry. I setted FBX_LIBRARY and FBX_LIBRARY_DEBUG directly and did not >> notice a problem. >> I changed FindFBX.cmake for correct selecting of library on windows. >> I noticed that dinamic linking is used on *nix(Debian 8 and FbxSDK 2017.0.1 >> in my case) by default. You should set FBX_LIBRARY and FBX_LIBRARY_DEBUG for >> static library. Thus i think that processing of FBX_SHARED is not needed on >> *nix. >> Unfortunately i can not check on the MAC. >> I attached new CMakeLists for fbx plugin and FindFBX.cmake. >> >> 14.11.2016, 18:27, "Voerman, L." <l.voer...@rug.nl>: >> >> Hi Chebaev, >> >> if you set FBX_SHARED to ON you will be awarded with a lot of linking >> errors, unless you know you should change libfbxsdk-md.lib into >> libfbxsdk.lib for FBX_LIBRARY and FBX_LIBRARY_DEBUG. >> I think you should at least provide a hint with this option. >> >> Regards, Laurens. >> >> On Mon, Nov 14, 2016 at 2:19 PM, Chebaev Vladimir <aluminium...@yandex.ru> >> wrote: >> >> Hello. >> Fbx plugin can not use "dll" variant of fbx SDK. >> It is not enough to set FBX_INCLUDE_DIR, FBX_LIBRARY and FBX_LIBRARY_DEBUG >> options for CMake. FBX_SHARED preprocessor definition should be setted. >> I changed src/osgPlugins/fbx/CMakeList.txt and added new option >> "FBX_SHARED". >> Fbx plugin will build without dinamic linking by default. If you set >> "FBX_SHARED" option to "ON" then preprocessor definition "FBX_SHARED" was >> enabled. >> I attached new CMakeList.txt >> _______________________________________________ >> osg-submissions mailing list >> osg-submissions@lists.openscenegraph.org >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> >> , >> >> _______________________________________________ >> osg-submissions mailing list >> osg-submissions@lists.openscenegraph.org >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> >> _______________________________________________ >> osg-submissions mailing list >> osg-submissions@lists.openscenegraph.org >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> _______________________________________________ osg-submissions mailing list osg-submissions@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
