On Thu, 2008-03-27 at 11:00 -0400, Jean-Sébastien Guay wrote:
> Hello Jeremy,
>
> I wanted to check out your progress with osgWidget since the last time,
> and ran into some warnings and errors compiling it. Here they are:
>
>
> First of all, I'm getting warnings "'const unsigned int' : forcing value
> to bool 'true' or 'false' (performance warning)" in EventInterface,
> lines 312, 314, 315, 316, 317, 318, 319, 321, 322. Essentially each time
> you do a binary AND, you have to do "!= 0" or something like that so
> that you return a boolean. For example:
>
> bool canFocus () const { return (_eventMask & EVENT_FOCUS) != 0; }
>
> Don't forget the parentheses for precedence.
Thanks for this; you caught these last time, too. :)
> Then, in Window.cpp, Label.cpp, Input.cpp, Canvas.cpp, round() is not
> defined on Windows (at least in the headers you're including). You could
> use osg::round() since you depend on OSG anyways.
Yeah someone else (I'm actually getting lots of e-mails lately about
osgWdiget, woot!) sent me this. They're fixed in my local (uncommitted)
source tree. They'll be committed today.
> After these changes, everything compiles correctly, and without warnings.
>
> The examples run well, except osgwidgetinput which gives me an Integer
> divide by zero in osg::Geometry::drawImplementation as soon as I pass
> the mouse over the text boxes. I can do a bit more testing in about a
> week if you want.
I can't figure this out and it's driving me batty. It doesn't happen if
I revert to old NVidia drivers, by the way.
Woeful, I say, woeful...
> All in all, good work!
>
> J-S
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
